Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Confirmation Sign Message detox spec file #6678

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

SamuelSalas
Copy link
Member

Description
Create Toggle Eth Sign Modal detox page and testIds files. Update EthSignFriction tsx file. Added ToggleEthSignModal steps on the sign messages spec

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

…SignFriction tsx file. Added ToggleEthSignModal steps on the sign messages spec
@SamuelSalas SamuelSalas requested a review from a team as a code owner June 22, 2023 19:34
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @SamuelSalas

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cortisiko cortisiko merged commit 3977154 into main Jun 22, 2023
11 checks passed
@cortisiko cortisiko deleted the fix/sign-messages-detox-spec branch June 22, 2023 21:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants