Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(on-ramp): upgrade on-ramp-sdk to v1.22.0 with abort controller support #6679

Merged
merged 10 commits into from
Jul 13, 2023
Merged

feat(on-ramp): upgrade on-ramp-sdk to v1.22.0 with abort controller support #6679

merged 10 commits into from
Jul 13, 2023

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR upgrades on-ramp-sdk to v1.22.0 and adopts AbortController support for the useSDKMethod hook

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jun 22, 2023
@wachunei wachunei requested a review from a team as a code owner June 22, 2023 19:43
@socket-security
Copy link

socket-security bot commented Jun 22, 2023 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@socket-security
Copy link

socket-security bot commented Jun 22, 2023 •
edited

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@consensys/on-ramp-sdk 1.20.0...1.22.0 None +3/-3 1.19 MB pmkowalski

@wachunei wachunei changed the title feature(on-ramp): upgrade on-ramp-sdk to v1.22.0 with abort controller support feat(on-ramp): upgrade on-ramp-sdk to v1.22.0 with abort controller support Jun 22, 2023
@wachunei
Copy link
Member Author

@SocketSecurity ignore-all

sethkfman
sethkfman approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 13, 2023
@bkirb
Copy link
Contributor

bkirb commented Jul 13, 2023

@wachunei LGTM I finished verifying this change

@wachunei wachunei added QA Passed A successful QA run through has been done and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jul 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wachunei wachunei merged commit f5f3e1f into main Jul 13, 2023
11 checks passed
@wachunei wachunei deleted the feature/onramp-use-sdk-method-abort-controller branch July 13, 2023 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.4.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @bkirb @sethkfman