refactor: split approvals into separate files #6687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create component for approval modal. Create component for watch asset approval. Create component for signature approval. Move accept and reject helpers to Engine.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Remove unnecessary component properties.
|
Kudos, SonarCloud Quality Gate passed! |
vstevam
approved these changes
Jul 24, 2023
vinistevam
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split all approval logic and rendering currently in
RootRPCMethodsUIinto separate components relying on a newuseApprovalRequesthook which reads theApprovalControllerstate from Redux rather than using an additional event listener.Also adds an
ApprovalModalcomponent to encapsulate the approval modal configuration currently duplicated for many different approvals.Reduces the
RootRPCMethodsUIsize by ~400 lines (~50%).E2E Test Run
Checklist