Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update multi select snapshot #6729

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: update multi select snapshot #6729

merged 1 commit into from
Jun 30, 2023
+2 −2

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jun 30, 2023 •
edited by NicolasMassart

Description
Fix the multi select snapshot

The snapshot was wrong after a PR updated the Checkbox component style.

Note
This wrong snapshot test passed into main without failing. We are now investigating the reason why it made it to main.

Screenshots/Recordings

image

Issue

NA

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jun 30, 2023
NicolasMassart
NicolasMassart approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tommasini tommasini changed the title fix update multi select snapshot fix: update multi select snapshot Jun 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

30.7% 30.7% Coverage
9.3% 9.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@tommasini tommasini merged commit f0a05aa into main Jun 30, 2023
15 of 16 checks passed
@tommasini tommasini deleted the fix/multi-select-snapshot branch June 30, 2023 17:52
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
release-7.3.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommasini @NicolasMassart @metamaskbot