Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing wallet_requestPermissions and wallet_getPermissions to the mobile API. #6732

Merged
merged 7 commits into from
Jul 20, 2023
Merged

feat: add missing wallet_requestPermissions and wallet_getPermissions to the mobile API. #6732

merged 7 commits into from
Jul 20, 2023

Conversation

shanejonas
Copy link
Contributor

Description
Added missing methods wallet_requestPermissions and wallet_getPermissions to the mobile API.

This brings it in line with the extension API so that dapps that build against requestPermissions don't have to have extra logic to do requestAccounts instead.

fixes https://github.com/MetaMask/MetaMask-planning/issues/861

Screenshots/Recordings

some screenshots of it working in the new api playground:

wallet_requestPermissions

image
image

error case:

image

wallet_getPermissions

image

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas shanejonas changed the title Fix/add request permissions feat: add missing wallet_requestPermissions and wallet_getPermissions to the mobile API. Jun 30, 2023
@socket-security
Copy link

socket-security bot commented Jun 30, 2023 •
edited

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/permission-controller 3.0.0...4.0.1 None +0/-0 400 kB metamaskbot

@shanejonas shanejonas force-pushed the fix/add-request-permissions branch from e41f734 to 44b66f3 Compare July 4, 2023 20:12
Cal-L
Cal-L previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanejonas shanejonas added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 5, 2023
@sethkfman
Copy link
Contributor

E2E Tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6463c0ac-989b-4240-82dc-20af3242a639

@shanejonas shanejonas requested a review from a team as a code owner July 13, 2023 16:11
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@sethkfman
Copy link
Contributor

E2E Run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbdfea59-e8f5-493c-9c1b-e7ac3dd9593c

sethkfman
sethkfman approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added release-7.5.0 No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. and removed release-7.4.0 labels Jul 20, 2023
@shanejonas shanejonas merged commit d3b4046 into main Jul 20, 2023
13 checks passed
@sethkfman sethkfman removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 20, 2023
@shanejonas shanejonas deleted the fix/add-request-permissions branch July 20, 2023 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@Woodpile37 Woodpile37 Woodpile37 approved these changes

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.5.0 team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shanejonas @sethkfman @Cal-L @Woodpile37