Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deeplink connection using metamask://connect #6739

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix: deeplink connection using metamask://connect #6739

merged 2 commits into from
Jul 10, 2023

Conversation

abretonc7s
Copy link
Contributor

Description

Fixes an issue with deeplink not establishing the connection properly.
Error was undetected due to deeplinkManager being a js file + default usage to universal links.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added deeplinks Deeplinks related issue or bug team-sdk SDK team labels Jul 4, 2023
andreahaku
andreahaku approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 4, 2023
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Jul 7, 2023
@christopherferreira9
Copy link
Contributor

Looking good! 🚀

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
100.0% 100.0% Duplication

@christopherferreira9 christopherferreira9 merged commit 90868cd into main Jul 10, 2023
9 of 11 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/deeplink_sdk branch July 10, 2023 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
deeplinks Deeplinks related issue or bug QA Passed A successful QA run through has been done release-7.4.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abretonc7s @christopherferreira9 @andreahaku @metamaskbot