Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PPOM integration with MetaMask mobile app #6749

Merged
merged 46 commits into from
Sep 5, 2023
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 6, 2023

PPOM Mobile Integration

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Jul 10, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ppom-validator 0.3.0 None +4 948 kB metamaskbot
react-native-webview-invoke 0.6.2 None +0 48 kB pinqy520
@types/crypto-js 4.1.1 None +0 59.9 kB types

@socket-security
Copy link

socket-security bot commented Jul 10, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: await-semaphore@0.1.3, react-native-webview-invoke@0.6.2

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@jpuri jpuri added the DO-NOT-MERGE Pull requests that should not be merged label Jul 14, 2023
@jpuri jpuri marked this pull request as ready for review July 14, 2023 10:17
@jpuri jpuri requested a review from a team as a code owner July 14, 2023 10:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.5% 15.5% Coverage
0.0% 0.0% Duplication

@jpuri
Copy link
Contributor Author

jpuri commented Aug 16, 2023

@SocketSecurity ignore-all

@jpuri jpuri removed the DO-NOT-MERGE Pull requests that should not be merged label Aug 16, 2023
@jpuri jpuri added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Aug 16, 2023
blackdevelopa
blackdevelopa previously approved these changes Aug 30, 2023
app/core/Engine.ts Outdated Show resolved Hide resolved
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Copy link
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. few comments

app/core/Engine.ts Outdated Show resolved Hide resolved
app/core/Engine.ts Show resolved Hide resolved
@jpuri jpuri requested a review from segun September 4, 2023 04:08
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

blackdevelopa
blackdevelopa previously approved these changes Sep 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

15.1% 15.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jpuri jpuri merged commit e2bc956 into main Sep 5, 2023
12 checks passed
@jpuri jpuri deleted the ppom_integration branch September 5, 2023 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants