Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete collectible media reproductor #6753

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: Delete collectible media reproductor #6753

merged 2 commits into from
Jul 7, 2023

Conversation

tommasini
Copy link
Contributor

Description
Delete unused component.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.4.0 labels Jul 6, 2023
sethkfman
sethkfman approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini tommasini merged commit 05c02a6 into main Jul 7, 2023
11 checks passed
@tommasini tommasini deleted the fix/822-delete-collectible-media-reproductor branch July 7, 2023 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leotm leotm leotm approved these changes

@gauthierpetetin gauthierpetetin gauthierpetetin approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.4.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tommasini @leotm @gauthierpetetin @sethkfman