-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sending an ERC20 token with an amount with more decimals than the token decimal, results in nothing #6754
Merged
blackdevelopa
merged 4 commits into
main
from
6324/sending-erc20-with-higher-token-decimal-error
Jul 12, 2023
Merged
fix: sending an ERC20 token with an amount with more decimals than the token decimal, results in nothing #6754
blackdevelopa
merged 4 commits into
main
from
6324/sending-erc20-with-higher-token-decimal-error
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
previously approved these changes
Jul 7, 2023
cryptotavares
previously approved these changes
Jul 10, 2023
digiwand
approved these changes
Jul 10, 2023
@blackdevelopa I can see how the issue is fixed now 🔥 PR can be merged send-token-decimals-erc20.mp4There is a related issue affecting deeplinks, in case you want to grab this in the future as it's related work. It's #6323 |
digiwand
previously approved these changes
Jul 11, 2023
606f8d1
e18b272
to
606f8d1
Compare
digiwand
approved these changes
Jul 11, 2023
cryptotavares
approved these changes
Jul 11, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
A successful QA run through has been done
release-7.4.0
team-confirmations-secure-ux-PR
PR from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Whenever we are trying to Send an ERC20 token, if we input an amount with more decimals than the contract is expecting, whenever we click Next, nothing happens. The improved solution is to mirror the extension by rounding off the number if it the fraction length is more than the token decimal
Screenshots/Recordings
Before:
235894032-42019be5-f7a0-421a-b450-504a23af58e7.mp4
After:
Screen.Recording.2023-07-07.at.04.43.56.mov
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #6324
Checklist