Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sdk protocol update #6755

Merged
merged 9 commits into from
Jul 12, 2023
Merged

feat: sdk protocol update #6755

merged 9 commits into from
Jul 12, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Jul 7, 2023 •
edited

  • Update sdk-communication-layer to 0.5.0
  • Connection management improvement and double call to goBack issue on android

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Jul 7, 2023 •
edited

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/sdk-communication-layer 0.3.0...0.5.0 None +0/-0 15.7 MB metamaskbot

@abretonc7s abretonc7s changed the title Feat/sdk protocol update feat: sdk protocol update Jul 7, 2023
@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team labels Jul 11, 2023
@abretonc7s abretonc7s marked this pull request as ready for review July 11, 2023 13:26
@christopherferreira9 christopherferreira9 added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 11, 2023
@abretonc7s abretonc7s requested a review from a team as a code owner July 12, 2023 10:27
andreahaku
andreahaku approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

3.2% 3.2% Coverage
0.0% 0.0% Duplication

@christopherferreira9 christopherferreira9 merged commit afb3df9 into main Jul 12, 2023
11 checks passed
@christopherferreira9 christopherferreira9 deleted the feat/sdk-protocol-update branch July 12, 2023 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 12, 2023
@christopherferreira9 christopherferreira9 added the QA Passed A successful QA run through has been done label Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
QA Passed A successful QA run through has been done release-7.4.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abretonc7s @andreahaku @christopherferreira9