refactor: Use selectors for token rates controller state access #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
added
the
No QA Needed/E2E Only
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
previously approved these changes
Jul 10, 2023
|
Unit test failures, possibly just outdated snapshots |
|
Oh, this test failure may be a problem on |
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
from
9e1448b
to
a573722
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
from
a573722
to
bbe5622
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
from
bbe5622
to
1cfa2a3
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
from
1cfa2a3
to
bfc8114
Compare
mcmire
reviewed
Jul 13, 2023
|
Another round of passing E2E tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0467dde4-0378-42f4-9e37-1a7cf8877e85 |
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
from
fee914c
to
8627951
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
2 times, most recently
from
d8d223d
to
73c8a5a
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-token-rates-controllers-state-access
branch
from
73c8a5a
to
dd66e58
Compare
|
Kudos, SonarCloud Quality Gate passed! |
cryptodev-2s
deleted the
use-selectors-for-token-rates-controllers-state-access
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Token Rates controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to TokenRatesController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1067
Checklist