refactor: Use selectors for account tracker controller state access #6762
+98
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
added
the
No QA Needed/E2E Only
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Jul 10, 2023
app/components/UI/AccountFromToInfoCard/AccountFromToInfoCard.types.tsx
Outdated
Show resolved
Hide resolved
Gudahtt
reviewed
Jul 10, 2023
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
4dabc06
to
92b5136
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
92b5136
to
68f0895
Compare
|
Passing e2e test run here: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8cd2a343-e352-45e1-ba61-b9dbd5a79664 |
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
114eb54
to
b54e70b
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
b54e70b
to
c20ad4a
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
c20ad4a
to
1461dc6
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
1461dc6
to
0e469a6
Compare
mcmire
reviewed
Jul 13, 2023
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
822e806
to
49aa729
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
3 times, most recently
from
1811590
to
56ce2ca
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-account-tracker-controllers-state-access
branch
from
56ce2ca
to
5e26d78
Compare
mcmire
approved these changes
Jul 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
cryptodev-2s
deleted the
use-selectors-for-account-tracker-controllers-state-access
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Account Tracker controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to AccountTrackerController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1059
Checklist