Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Added horizontalAlignment to Accordions #6766

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

brianacnguyen
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • Added horizontalAlignment to Accordions
  • Updated const and story files

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile team-design-system labels Jul 7, 2023
@brianacnguyen brianacnguyen requested a review from segun July 7, 2023 21:13
@brianacnguyen brianacnguyen self-assigned this Jul 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title Added horizontalAlignment to Accordions style: Added horizontalAlignment to Accordions Jul 10, 2023
segun
segun previously approved these changes Jul 10, 2023
@segun segun requested a review from a team as a code owner July 12, 2023 14:20
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit a85bbc6 into main Jul 12, 2023
11 checks passed
@brianacnguyen brianacnguyen deleted the morph/accordion-update branch July 12, 2023 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.4.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants