refactor: Use selectors for token list controller state access #6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
added
the
No QA Needed/E2E Only
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cryptodev-2s
force-pushed
the
use-selectors-for-token-list-controllers-state-access
branch
from
d27d407
to
0722e37
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-token-list-controllers-state-access
branch
from
0722e37
to
353b73a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
cryptodev-2s
deleted the
use-selectors-for-token-list-controllers-state-access
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Token list controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to TokenListController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1066
Checklist