Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix pipelines to reflect running tests on android detox #6796

Merged
merged 2 commits into from
Jul 13, 2023
Merged

ci: Fix pipelines to reflect running tests on android detox #6796

merged 2 commits into from
Jul 13, 2023

Conversation

cortisiko
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The run_e2e_android_pipeline and release_e2e_pipeline are running tests against the incorrect test framework. This PR ensures that both these pipelines trigger the android detox tests.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko cortisiko requested a review from a team as a code owner July 12, 2023 23:15
@cortisiko cortisiko added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jul 12, 2023
Gudahtt
Gudahtt approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Cal-L
Cal-L approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 2c22d46 into main Jul 13, 2023
13 checks passed
@cortisiko cortisiko deleted the bitrise/fix_pipelines_to_reflect_android_detox branch July 13, 2023 00:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cortisiko @Gudahtt @Cal-L @metamaskbot