Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send flow UI updates #6802

Merged
merged 12 commits into from
Jul 14, 2023
Merged

feat: Send flow UI updates #6802

merged 12 commits into from
Jul 14, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jul 13, 2023

Description
This PR aims to update the send flow UI on this figma file

Also, it was updated the Contacts view on settings was since they shared the same component

This PR also is deleting the recents from the send flow and it's underneath logic

Technical detais
AddressElement, AddressList, and IdentIcon updated to typescript and to functional components.

Deleted recents from the redux state, freeing more memory. Created a migration for the existing users.

Screenshots/Recordings
http://recordit.co/7eR0wBAfbA

E2E build
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3e17674-c28d-4790-a402-1eadaf3fb1ad
Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner July 13, 2023 18:48
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-7.4.0 No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Jul 13, 2023
@tommasini
Copy link
Contributor Author

tommasini commented Jul 13, 2023

Regarding the SonarCloud bug:
image
The intention it's to order alphabetically so now need to address it in my opinion, but let me know your thoughts on this

Thanks to SonarCloud I could see that just sort() is that that accurate and can lead to different results on some cases!

@tommasini tommasini force-pushed the update/831-send-flow-ui-update branch from 629c7b6 to 6fd7a4d Compare July 13, 2023 19:29
@tommasini
Copy link
Contributor Author

Rebuilt entirely pipeline with the latest changes: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3e17674-c28d-4790-a402-1eadaf3fb1ad

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.1% 60.1% Coverage
0.0% 0.0% Duplication

@tommasini tommasini merged commit 66affd6 into main Jul 14, 2023
11 checks passed
@tommasini tommasini deleted the update/831-send-flow-ui-update branch July 14, 2023 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants