Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update button constants structure to prevent require cycle #6808

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: Update button constants structure to prevent require cycle #6808

merged 1 commit into from
Jul 14, 2023

Conversation

brianacnguyen
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • Updated ButtonBase.constants to not require Button.constants to break the unnecessary require cycle

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 14, 2023
@brianacnguyen brianacnguyen self-assigned this Jul 14, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner July 14, 2023 15:38
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

tommasini
tommasini approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOP!! Thanks! LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit 040aa5e into main Jul 14, 2023
13 checks passed
@brianacnguyen brianacnguyen deleted the mobile/button-cycle-fix branch July 14, 2023 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 14, 2023
@tommasini tommasini added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.5.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianacnguyen @tommasini @metamaskbot