Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use selectors for nft controller state access #6820

Merged
merged 1 commit into from
Jul 18, 2023
Merged

refactor: Use selectors for nft controller state access #6820

merged 1 commit into from
Jul 18, 2023

Conversation

cryptodev-2s
Copy link
Contributor

Description

Nft controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.

Most of these changes consist of replacing the direct access to NftController State, by selectors.

Issue

Relates to https://github.com/MetaMask/mobile-planning/issues/1062

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cryptodev-2s cryptodev-2s added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jul 17, 2023
@cryptodev-2s cryptodev-2s self-assigned this Jul 17, 2023
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner July 17, 2023 13:58
@cryptodev-2s cryptodev-2s changed the title refactor: Use selectors for token nft controller state access refactor: Use selectors for nft controller state access Jul 17, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the use-selectors-for-nft-controllers-state-access branch 2 times, most recently from eaa0bf5 to 5ab41d0 Compare July 17, 2023 13:59
@cryptodev-2s
Copy link
Contributor Author

successful e2e https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b6b3ab8-8017-4536-bea6-360428af3f3a

@cryptodev-2s cryptodev-2s force-pushed the use-selectors-for-nft-controllers-state-access branch from 5ab41d0 to 1916d2d Compare July 17, 2023 17:17
@cryptodev-2s cryptodev-2s requested a review from mcmire July 17, 2023 17:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.6% 78.6% Coverage
0.0% 0.0% Duplication

mikesposito
mikesposito approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I linked the issue to this PR

Cal-L
Cal-L approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptodev-2s cryptodev-2s merged commit 303afd3 into main Jul 18, 2023
11 checks passed
@cryptodev-2s cryptodev-2s deleted the use-selectors-for-nft-controllers-state-access branch July 18, 2023 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@mikesposito mikesposito mikesposito approved these changes

@mcmire mcmire Awaiting requested review from mcmire

Assignees

@cryptodev-2s cryptodev-2s

Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cryptodev-2s @Cal-L @mikesposito @hesterbruikman @metamaskbot