Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet connect v1 is fully deprecated #6828

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

tommasini
Copy link
Contributor

Description
This PR aims to start removing code of the wallet connect v1, that it's fully deprecated

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner July 18, 2023 07:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title wallet connect v1 is fully deprecated fix: wallet connect v1 is fully deprecated Jul 18, 2023
Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we can probably fully remove classes soon.

https://docs.walletconnect.com/2.0/advanced/migration-from-v1.x/overview

@tommasini tommasini added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.5.0 labels Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tommasini tommasini merged commit a2f00c2 into main Jul 19, 2023
11 checks passed
@tommasini tommasini deleted the feat/827-wallet-connect branch July 19, 2023 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.5.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants