feat: add support for template and header result pages #6832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
force-pushed
the
1028-support-header-template
branch
from
a7c49fb
to
67ce48d
Compare
app/components/UI/MetamaskTemplateRenderer/MetamaskTemplateRenderer.js
Outdated
Show resolved
Hide resolved
app/components/UI/MetamaskTemplateRenderer/MetamaskTemplateRenderer.js
Outdated
Show resolved
Hide resolved
app/components/UI/MetamaskTemplateRenderer/MetamaskTemplateRenderer.js
Outdated
Show resolved
Hide resolved
app/components/UI/MetamaskTemplateRenderer/SafeComponentList.js
Outdated
Show resolved
Hide resolved
vinistevam
force-pushed
the
1028-support-header-template
branch
from
3954f17
to
c551d97
Compare
vinistevam
force-pushed
the
1028-support-header-template
branch
from
c551d97
to
0fc32bb
Compare
app/components/Approvals/TemplateConfirmationModal/TemplateConfirmationModal.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Outdated
Show resolved
Hide resolved
app/components/Approvals/TemplateConfirmationModal/TemplateConfirmationModal.tsx
Show resolved
Hide resolved
app/components/Approvals/TemplateConfirmationModal/TemplateConfirmationModal.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/Approval/TemplateConfirmation/Templates/index.ts
Outdated
Show resolved
Hide resolved
app/components/UI/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Show resolved
Hide resolved
vinistevam
added
the
team-confirmations-system
|
Kudos, SonarCloud Quality Gate passed!
|
matthewwalsh0
approved these changes
Aug 3, 2023
OGPoyraz
approved these changes
Aug 3, 2023
metamaskbot
added
the
release-7.6.0
vinistevam
added
the
No QA Needed/E2E Only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR aims to include support for header and components on result pages (success & error). Additionally, it also includes support for templates identical to what already exists in the extension.
MetamaskTemplateRendererwith asafeComponentListto ensure only allow components can be rendered.Screenshots/Recordings
Note: the recordings below are for testing the components no change was done on the add & switch approval.
header_template_support_error.webm
header_template_support_success.webm
Issue
Progresses: https://github.com/MetaMask/mobile-planning/issues/1028
Pipeline E2E
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6836897f-b4ef-4564-8707-68419ad75ca3
Checklist