Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Android filename validation when downloading from browser #6844

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix: Android filename validation when downloading from browser #6844

merged 2 commits into from
Jul 25, 2023

Conversation

sethkfman
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Added filename validation and user feedback when downloading files in Android browser

Screenshots/Recordings

See linked issues for video

Issue

NA

Checklist

  • There is a related GitHub issue
  • [NA] Tests are included if applicable
  • Any added code is fully documented

@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 19, 2023
@sethkfman sethkfman requested a review from a team as a code owner July 19, 2023 22:12
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jul 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Cal-L
Cal-L approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 21, 2023
@sethkfman sethkfman merged commit 19e52f7 into main Jul 25, 2023
13 checks passed
@sethkfman sethkfman deleted the fix/android-filename-validation branch July 25, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@NicholasEllul NicholasEllul Awaiting requested review from NicholasEllul

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethkfman @Cal-L