refactor: Use Redux network controller state #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
the
needs-dev-review
Gudahtt
force-pushed
the
replace-some-direct-network-state-references
branch
from
7e8ea70
to
a2b9ffd
Compare
Gudahtt
force-pushed
the
replace-some-direct-network-state-references
branch
from
a2b9ffd
to
20ae552
Compare
3 tasks
Gudahtt
added
the
No QA Needed/E2E Only
Various UI components have been updated to use Redux network controller state (via selectors) rather than directly accessing the controller state using the `Engine` global. Relates to MetaMask/mobile-planning#1016
Gudahtt
force-pushed
the
replace-some-direct-network-state-references
branch
from
20ae552
to
dd93a8e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Cal-L
added
release-7.5.0
and removed
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Various UI components have been updated to use Redux network controller state (via selectors) rather than directly accessing the controller state using the
Engineglobal.Issue
Relates to MetaMask/mobile-planning#1016
Checklist