Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update README.md #6853

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: update README.md #6853

merged 1 commit into from
Aug 2, 2023

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Jul 21, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Update CMake, device versions.

Screenshots/Recordings
Screenshot 2023-07-19 at 10 29 34 PM

Screenshot 2023-07-20 at 12 24 35 AM
Screenshot 2023-07-19 at 10 29 17 PM

Issue

Outdated mobile environment setup description.

Checklist

  • [N/A ] There is a related GitHub issue
  • [ N/A] Tests are included if applicable
  • Any added code is fully documented

@sleepytanya sleepytanya requested a review from a team as a code owner July 21, 2023 00:42
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 21, 2023
@sleepytanya
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sleepytanya sleepytanya self-assigned this Aug 2, 2023
NicolasMassart
NicolasMassart approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sleepytanya sleepytanya merged commit e426592 into main Aug 2, 2023
14 checks passed
@sleepytanya sleepytanya deleted the fix-readme1 branch August 2, 2023 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 2, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

@sleepytanya sleepytanya

Labels
release-7.6.0 Issue or pull request that will be included in release 7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sleepytanya @NicolasMassart @metamaskbot