fix: misalignment issue for multiselect cells #6863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianacnguyen
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
brianacnguyen
changed the title
brianacnguyen
changed the title
chrisleewilcox
requested changes
Jul 25, 2023
There was a problem hiding this comment.
@brianacnguyen we established a new process where all PRs need to run the pr_smoke_e2e_pipeline workflow in bitrise and have all test pass before merging PRs into main branch. I can show you how to run it if needed just let me know.
brianacnguyen
force-pushed
the
morph/cell-fix
branch
from
6921b5b
to
29acce5
Compare
brianacnguyen
force-pushed
the
morph/cell-fix
branch
from
29acce5
to
df423ce
Compare
…to morph/cell-fix
|
Kudos, SonarCloud Quality Gate passed!
|
chrisleewilcox
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Fix misalignment issue for multiselect cells
Screenshots/Recordings
bitrise smoketest: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e82e45cf-47a7-4527-af39-61e074b62f7a
Issue
https://app.zenhub.com/workspaces/mobile-release-regression-6249e5242464b70013315a98/issues/gh/metamask/mobile-planning/1146
Progresses #???
Checklist