refactor: Simplify handleNetworkSwitch helper
#6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
needs-dev-review
|
Successful e2e test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcb12164-9033-4a54-a04b-f0adc815d09f |
Gudahtt
force-pushed
the
refactor-handle-network-switch
branch
4 times, most recently
from
a09da1b
to
8d209fe
Compare
3 tasks
Gudahtt
force-pushed
the
refactor-handle-network-switch
branch
7 times, most recently
from
d4e7ae2
to
7b80a15
Compare
The `handleNetworkSwitch` helper function no longer requires the `frequentRpcList` state as a parameter. Instead it takes a reference to the `PreferencesController`, and gets the RPC list state from that. Typically it would be preferrable to reference controller state from Redux rather than accesing it directly from the Engine global. However, this function will be called from non-UI contexts, so it has to get controller state from global context regardless. This change was done to simplify PR #6872, which is part of MetaMask/mobile-planning#798
Gudahtt
force-pushed
the
refactor-handle-network-switch
branch
from
7b80a15
to
21f6bd4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The
handleNetworkSwitchhelper function no longer requires thefrequentRpcListstate as a parameter. Instead it takes a reference to thePreferencesController, and gets the RPC list state from that.Typically it would be preferrable to reference controller state from Redux rather than accesing it directly from the Engine global. However, this function will be called from non-UI contexts, so it has to get controller state from global context regardless.
Issue
This change was done to simplify PR #6872, which is part of https://github.com/MetaMask/mobile-planning/issues/798
Checklist