Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type declaration for deprecated Checkbox library #6896

Merged

Conversation

pedrosimao
Copy link
Contributor

Description

Added a type declaration that overwrites the original @react-native-community/checkbox type, so we can have a deprecation message visible on IDEs

_1. What is the reason for the change?

Make developers aware that @react-native-community/checkbox is deprecated.

Screenshots/Recordings

Screenshot 2023-07-25 at 16 06 28

Issue

#6885

Checklist

  • There is a related GitHub issue

@pedrosimao pedrosimao requested a review from a team as a code owner July 25, 2023 15:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedrosimao
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label Jul 25, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedrosimao, this is great! I pulled your branch and checked that the deprecation message is working as intended. I just want to check with @Cal-L that this would be a scalable way to deprecate third-party libraries in favour of the component-library components

@georgewrmarshall
Copy link
Contributor

Also looks like there is a conventional commit convention that needs to be addressed

@pedrosimao
Copy link
Contributor Author

pedrosimao commented Jul 25, 2023

Ohh, sorry, I just noticed I should have documented the update in the changelog, right? I will fix that.

@pedrosimao pedrosimao force-pushed the feature/refactor-checkbox-comments branch 2 times, most recently from 31e130b to eeeafd8 Compare July 25, 2023 20:48
@pedrosimao
Copy link
Contributor Author

@georgewrmarshall Ok, commit name fixed... I guess the changelog is generated automatically based on the commit title? (which is not according to Conventional Commits)
If @Cal-L thinks this is a good way of documenting deprecation of external Libs I will go ahead and do the same for the other libs that are also being deprecated (on other github issues)

@georgewrmarshall georgewrmarshall force-pushed the feature/refactor-checkbox-comments branch from eeeafd8 to 60bba85 Compare August 2, 2023 15:07
@pedrosimao
Copy link
Contributor Author

@georgewrmarshall any news on this one?

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Aug 18, 2023

Hey @pedrosimao, thanks for following up. I'll make sure to chase this up with the mobile team next week. We've all just got back from a week break so apologies for the lack of correspondence on this. Thanks for your patience

@georgewrmarshall
Copy link
Contributor

Hey @pedrosimao, we recently updated SonarCloud settings so external contributor PRs would pass but I think you may have to close this PR and create a new one. Would you mind doing that and we should be able to get this in

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrosimao
Copy link
Contributor Author

@georgewrmarshall no problem. I just re-synced my original branch and it seems the SonarCloud actions along with the other jobs were passed again. Let me know if I still need to create a new PR (and close this one). Anyway I think it stills need a second review approval. Whenever we will be able to merge this PR I can add more deprecate the other libs and replace them (according to the open issues).

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @pedrosimao 🙏

@georgewrmarshall georgewrmarshall merged commit 1b518be into MetaMask:main Oct 10, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants