-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type declaration for deprecated Checkbox library #6896
Added type declaration for deprecated Checkbox library #6896
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pedrosimao, this is great! I pulled your branch and checked that the deprecation message is working as intended. I just want to check with @Cal-L that this would be a scalable way to deprecate third-party libraries in favour of the component-library components
Also looks like there is a conventional commit convention that needs to be addressed |
Ohh, sorry, I just noticed I should have documented the update in the |
31e130b
to
eeeafd8
Compare
@georgewrmarshall Ok, commit name fixed... I guess the changelog is generated automatically based on the commit title? (which is not according to Conventional Commits) |
eeeafd8
to
60bba85
Compare
@georgewrmarshall any news on this one? |
Hey @pedrosimao, thanks for following up. I'll make sure to chase this up with the mobile team next week. We've all just got back from a week break so apologies for the lack of correspondence on this. Thanks for your patience |
Hey @pedrosimao, we recently updated SonarCloud settings so external contributor PRs would pass but I think you may have to close this PR and create a new one. Would you mind doing that and we should be able to get this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@georgewrmarshall no problem. I just re-synced my original branch and it seems the SonarCloud actions along with the other jobs were passed again. Let me know if I still need to create a new PR (and close this one). Anyway I think it stills need a second review approval. Whenever we will be able to merge this PR I can add more deprecate the other libs and replace them (according to the open issues). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @pedrosimao 🙏
Description
Added a type declaration that overwrites the original
@react-native-community/checkbox
type, so we can have adeprecation
message visible on IDEs_1. What is the reason for the change?
Make developers aware that
@react-native-community/checkbox
is deprecated.Screenshots/Recordings
Issue
#6885
Checklist