feat: Migrate wdio 'SendEthMultisig' test to Detox #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepytanya
added
No QA Needed/E2E Only
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sleepytanya
changed the title
chrisleewilcox
added
needs-dev-review
There was a problem hiding this comment.
@sleepytanya please run the pr_smoke_e2e_pipelin workflow on bitrise for you branch before dev review and provide the link to the bitrise test results in this PR.
cortisiko
requested changes
Jul 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedNo QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)Description:
This PR converts Appium E2E test to Detox.
E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6e6f2584-baac-48a3-bf8c-f4d80b60e2ca?tab=workflows
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
fixes #???
Checklist