refactor: Update core controllers (v47)

[Gudahtt]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add the appropiate QA label when dev review is completed
   • needs-qa: PR requires manual QA.
   • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
   • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

The package @metamask/assets-controllers has been updated to v6, which brings core packages up-to-date with v47 of the core monorepo.

Issue

This closes https://github.com/MetaMask/mobile-planning/issues/877

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/assets-controllers	5.1.0...6.0.0	None	+0/-0	600 kB	metamaskbot

[Gudahtt]

This has been rebased onto #6902

Passing e2e test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e6851f8-0d0f-40c2-8c13-655ee997779b

[codecov-commenter]

Codecov Report

Merging #6964 (123356c) into main (30e9e40) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6964   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files         993      993           
  Lines       26614    26614           
  Branches     2083     2083           
=======================================
  Hits         8713     8713           
  Misses      17487    17487           
  Partials      414      414           

Files Changed	Coverage Δ
app/core/Engine.ts	57.84% <100.00%> (ø)

[tommasini]

Since setProviderType is now async, should we create an issue to change the codebase?
Since this controller update only changes the assets-controllers version, I don't know if it would be okay to do it here.

Let me know what do you think

I'm a little bit confused, the setProviderType on the change log of version 47 is turned to async, but on the change log of the network controller it's just on version 8.0.0. I believe this will not crash anything, but just checking if we should update the network controllers to 8.0.0 to do this update on assets-controllers.

[Gudahtt]

Thanks for looking into that @tommasini . I hadn't noticed that entry before. It looks like it's invalid.

The linked PR is indeed for the network controller - the only impact it had on assets-controllers was in a test. That network controller change wasn't even included in that release - it was in v48, the release after this one. So that entry is invalid for two different reasons. I'll update it now. (Edit: done here: MetaMask/core#1619 )

[Gudahtt]

This was the only functional change for assets-controllers in that release: MetaMask/core#1166

[tommasini]

Thanks for the explanation and for looking into that!!
Looks good to me 🚀

The base branch was changed.

[Gudahtt]

The blockers have been merged, so this has been rebased onto main

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[cortisiko]

Hey @Gudahtt, testing is still ongoing. I did however notice a bug.

After importing a wallet, I notice my transaction history is not displayed. See the recording here: http://recordit.co/Wsn77E1xy2

Compared to prod v7.5: http://recordit.co/02UDZRtvci

To reproduce:
Import a wallet with transaction history on mainnet
when you get to the wallet view go to the transaction history view
notice previous transactions do not appear

[cortisiko]

Looks good. ✅

[Gudahtt]

For further context on the bug referenced a few comments back: we later discovered that it was introduced by #6998 and is being addressed in #7042