Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing long press event for account removal #6990

Merged
merged 4 commits into from
Aug 21, 2023
Merged

fix: Add missing long press event for account removal #6990

merged 4 commits into from
Aug 21, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Aug 15, 2023

Description

This PR re-adds the ability to remove imported accounts via long press

Screenshots/Recordings

Steps to verify the fix:

  • Import an account
  • Open account selection on either the wallet or browser screen
  • Long press the imported account and you should see the remove prompt
  • Proceed to remove account
  • Imported account should be successfully removed

Removing from wallet screen
https://github.com/MetaMask/metamask-mobile/assets/10508597/b873556a-6649-4733-8013-99d7b2124501

Removing from browser screen
https://github.com/MetaMask/metamask-mobile/assets/10508597/bfebbe93-57b5-4f26-9ecf-2859ad1a59ef

Issue

#6985

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner August 15, 2023 16:44
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L
Copy link
Contributor Author

Cal-L commented Aug 15, 2023

Can't connect #6985 for some reason...

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Aug 15, 2023
sethkfman
sethkfman previously approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 17, 2023
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023 •
edited

Codecov Report

Merging #6990 (57ffb99) into main (872d201) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6990   +/-   ##
=======================================
  Coverage   32.65%   32.65%           
=======================================
  Files         994      994           
  Lines       26646    26646           
  Branches     2089     2089           
=======================================
  Hits         8700     8700           
  Misses      17532    17532           
  Partials      414      414
Files Changed Coverage Δ
...components/Select/Select/SelectItem/SelectItem.tsx 100.00% <ø> (ø)

sethkfman
sethkfman approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Cal-L Cal-L merged commit 2c4ab04 into main Aug 21, 2023
11 checks passed
@Cal-L Cal-L deleted the fix/1153-remove-import-account branch August 21, 2023 23:57
@Cal-L Cal-L added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 22, 2023
@cortisiko cortisiko removed the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 22, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Cal-L @codecov-commenter @sethkfman @gauthierpetetin @cortisiko @metamaskbot