chore: fix ios simulator qa build

[jpcloureiro]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add the appropiate QA label when dev review is completed
   • needs-qa: PR requires manual QA.
   • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
   • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

command yarn start:ios:qa fails to launch the app on iOS simulator

Updating the xcode build command to use react-native CLI fixes the problem

UPDATE

see #6996 (comment)

Screenshots/Recordings

Before:
video link

After:
video link

Issue

fixes #???

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[MarioAslau]

LGTM!

[tommasini]

LGTM!

[jpcloureiro]

@cortisiko Mentioned this change no longer outputs the derived data on the ios/build/ path. This is needed to run Appium tests locally.

I will address that case on this PR

E2E tests with QA builds on bitrise will be tested as well

[jpcloureiro]

We want to use react-native cli run-ios command & use default xcode derived data.
CLI cant install the app on the simulator if not using the default derived data path.

Using default derived data also allows builds from CLI & xcode to share the same cache, improving build times. See more: react-native-community/cli#908

The bitrise E2E tests should not be impacted because they don't rely on iOS debug builds.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[codecov-commenter]

Codecov Report

Merging #6996 (b6177eb) into main (b43b10b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6996   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files         993      993           
  Lines       26614    26614           
  Branches     2083     2083           
=======================================
  Hits         8713     8713           
  Misses      17487    17487           
  Partials      414      414           

[cortisiko]

This PR fixes the build path issue. the iOS QA app built correctly on bitrise and the E2E tests for detox passed Thanks @jpcloureiro !