Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change fox svg code #7013

Merged
merged 3 commits into from
Aug 17, 2023
Merged

fix: change fox svg code #7013

merged 3 commits into from
Aug 17, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Aug 17, 2023 •
edited

Description
Change svg fox code

Screenshots/Recordings
image

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.6.0 Issue or pull request that will be included in release 7.6.0 labels Aug 17, 2023
@tommasini tommasini requested a review from a team as a code owner August 17, 2023 19:36
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7013 (6984395) into main (a4f47f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7013   +/-   ##
=======================================
  Coverage   32.65%   32.65%           
=======================================
  Files         996      996           
  Lines       26644    26644           
  Branches     2084     2084           
=======================================
  Hits         8701     8701           
  Misses      17529    17529           
  Partials      414      414

@hesterbruikman hesterbruikman added the design-review Any feature that needs feedback from the design team label Aug 17, 2023
Cal-L
Cal-L approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanrong-chen
Copy link

Looks good to me now, thank you @tommasini!

MarioAslau
MarioAslau approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tommasini tommasini removed the design-review Any feature that needs feedback from the design team label Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini merged commit 27fbcdf into main Aug 17, 2023
12 checks passed
@tommasini tommasini deleted the fix-fox-logo branch August 17, 2023 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees
No one assigned
Labels
release-7.6.0 Issue or pull request that will be included in release 7.6.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tommasini @codecov-commenter @yanrong-chen @Cal-L @MarioAslau @gauthierpetetin @hesterbruikman