docs: Update JSDoc to deprecate Text Component Usage #7021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated deprecation JSDoc to deprecated code in Text.tsx
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
georgewrmarshall
added
the
team-design-system
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7021 +/- ##
=======================================
Coverage 32.82% 32.82%
=======================================
Files 998 998
Lines 26671 26671
Branches 2091 2091
=======================================
Hits 8755 8755
Misses 17498 17498
Partials 418 418
☔ View full report in Codecov by Sentry. |
georgewrmarshall
approved these changes
Aug 28, 2023
|
Hey @kshavp, we recently updated SonarCloud settings so external contributor PRs would pass but I think you may have to close this PR and create a new one. Would you mind doing that and we should be able to get this in |
brianacnguyen
approved these changes
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated deprecation JSDoc to deprecated code in Text.tsx
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
fixes #6888
Checklist