Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(action): octokit not supported on MetaMask repos #7024

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix(action): octokit not supported on MetaMask repos #7024

merged 2 commits into from
Aug 23, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Aug 21, 2023 •
edited

Description

The github action was constantly failing with the following error: octokit/request-action@v2.x is not allowed to be used in MetaMask/metamask-mobile.

The fix is to use a curl instead of using octokit.

Screenshots/Recordings

Issue

  • None, it's just a fix to the PR mentioned above.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gauthierpetetin
fix(action): octokit not supported on MetaMask repos
7e82574 
The github action was constantly failing with the following error: octokit/request-action@v2.x is not allowed to be used in MetaMask/metamask-mobile. The fix is to use a curl instead of using octokit.
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner August 21, 2023 12:10
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin
fix(action): shellcheck was failing
91add9b 
Shellcheck was failing in the CI. Had to craft the payload of the curl before doing the curl to fix this.
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

tommasini
tommasini approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthierpetetin gauthierpetetin merged commit b43b10b into main Aug 23, 2023
11 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/bug-report-issue branch August 23, 2023 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees
No one assigned
Labels
release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gauthierpetetin @tommasini @metamaskbot