Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new translations for nft mdia #7026

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat: new translations for nft mdia #7026

merged 1 commit into from
Aug 21, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Aug 21, 2023 •
edited

More info here

Screenshots
image
image
image
image

@tommasini tommasini requested a review from a team as a code owner August 21, 2023 15:35
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added team-mobile-client team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 21, 2023
sethkfman
sethkfman approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Aug 21, 2023
@tommasini tommasini merged commit a9a4506 into main Aug 21, 2023
16 checks passed
@tommasini tommasini deleted the translations/1166-nft-media branch August 21, 2023 16:16
@tommasini tommasini added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 21, 2023
@gauthierpetetin gauthierpetetin added blocked in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed blocked in-progress labels Aug 24, 2023
@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress labels Sep 6, 2023
@gauthierpetetin gauthierpetetin removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
blocked release-7.6.0 Issue or pull request that will be included in release 7.6.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommasini @sethkfman @gauthierpetetin