fix: crowdin action upload #7029
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethkfman
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## main #7029 +/- ##
=======================================
Coverage 32.65% 32.65%
=======================================
Files 994 994
Lines 26646 26646
Branches 2089 2089
=======================================
Hits 8700 8700
Misses 17532 17532
Partials 414 414 |
|
Kudos, SonarCloud Quality Gate passed!
|
Cal-L
added
No QA Needed/E2E Only
gauthierpetetin
added
the
needs-dev-review
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
This PR fixes the broken Crowdin Action. A previous PR was introduced to disable the uploading of translations to Crowdin but the PR broke the action. The changes added the translation files back and disabled the uploading in the action. For some reason the GH action requires a translation path, if you disable the upload in the action file it doesn't upload translations as desired.
Evidence Links/Screenshots/Recordings
Link to a successful Crowdin Action
Checklist