Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockaid preference #7038

Merged
merged 58 commits into from
Sep 5, 2023
Merged

Blockaid preference #7038

merged 58 commits into from
Sep 5, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Aug 22, 2023

  1. Adding patch to preference controller for this change: MetaMask/core@509fb93
  2. Integrating preference controller change with ppom controller

Base automatically changed from ppom_integration to main September 5, 2023 15:09
@jpuri jpuri dismissed blackdevelopa’s stale review September 5, 2023 15:09

The base branch was changed.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@segun
Copy link
Contributor

segun commented Sep 5, 2023

I need to update one of my metrics PR once this is merged.

@jpuri jpuri merged commit 87d50ba into main Sep 5, 2023
12 checks passed
@jpuri jpuri deleted the blockaid_preference branch September 5, 2023 23:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants