Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Detox rename correct failing tests #7048

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

chrisleewilcox
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
  6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description
Renaming the correct flaky test to disable.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@chrisleewilcox chrisleewilcox added tests Test related issues needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Aug 23, 2023
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner August 23, 2023 17:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox changed the title chroe(tests): Detox rename correct failing tests chore(tests): Detox rename correct failing tests Aug 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7048 (267681d) into main (ee759e8) will increase coverage by 0.03%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7048      +/-   ##
==========================================
+ Coverage   32.69%   32.73%   +0.03%     
==========================================
  Files         993      993              
  Lines       26606    26614       +8     
  Branches     2083     2083              
==========================================
+ Hits         8700     8713      +13     
+ Misses      17492    17487       -5     
  Partials      414      414              

see 40 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@chrisleewilcox chrisleewilcox merged commit de1dc4a into main Aug 23, 2023
15 of 16 checks passed
@chrisleewilcox chrisleewilcox deleted the detox/rename_failing_tests branch August 23, 2023 18:25
@chrisleewilcox chrisleewilcox removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@chrisleewilcox chrisleewilcox added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 23, 2023
@chrisleewilcox chrisleewilcox restored the detox/rename_failing_tests branch August 23, 2023 18:28
@chrisleewilcox chrisleewilcox deleted the detox/rename_failing_tests branch August 23, 2023 18:30
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead tests Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants