Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update terms of use header to match new copy #7050

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

frankvonhoven
Copy link
Contributor

Description

Update copy on Terms of Use modal header to improve UX.

Screenshots/Recordings
terms-header-updated

Issue

fixes https://github.com/MetaMask/mobile-planning/issues/1205

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client labels Aug 23, 2023
@frankvonhoven frankvonhoven requested a review from a team as a code owner August 23, 2023 18:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 23, 2023
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #7050 (9da15f3) into main (de1dc4a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7050   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files         993      993           
  Lines       26614    26614           
  Branches     2083     2083           
=======================================
  Hits         8713     8713           
- Misses      17487    17489    +2     
+ Partials      414      412    -2     

see 1 file with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Cal-L Cal-L added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 23, 2023
@gauthierpetetin gauthierpetetin added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Aug 23, 2023
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 23, 2023
@frankvonhoven frankvonhoven merged commit dc1e479 into main Aug 23, 2023
22 checks passed
@frankvonhoven frankvonhoven deleted the fix/1205-update-terms-of-use-header branch August 23, 2023 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.7.0 Issue or pull request that will be included in release 7.7.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants