test: Expand interaction capabilities in test cases using fixtures #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistevam
added
the
team-confirmations-system
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cortisiko
reviewed
Aug 24, 2023
e2e/specs/permission-system-revoke-single-account-fixture.spec.js
Outdated
Show resolved
Hide resolved
vinistevam
changed the title
vinistevam
force-pushed
the
improve-interactions-in-test-cases-with-fixture
branch
from
20a4710
to
290bb5a
Compare
vinistevam
changed the title
vinistevam
changed the title
Codecov Report
@@ Coverage Diff @@
## main #7057 +/- ##
==========================================
- Coverage 32.83% 32.82% -0.01%
==========================================
Files 998 998
Lines 26666 26671 +5
Branches 2091 2091
==========================================
- Hits 8756 8755 -1
- Misses 17492 17498 +6
Partials 418 418
|
Andepande
previously approved these changes
Aug 25, 2023
cortisiko
approved these changes
Aug 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
vinistevam
added
the
No QA Needed/E2E Only
metamaskbot
added
the
release-7.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
When working on more complex flows using fixtures there was some limitation on overwriting some actions while the test ran. In order to improve and expand the fixture's capabilities the changes were applied:
ApprovalControllerand removePersonalMessageManagerandTypedMessageManager.withPermissionControllerConnectedToTestDappto have the app connected to the test dapp.createStoreinstead of overwriting the store's getState function.Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
E2E
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64a4361e-c3ce-4ef9-b570-f878f6dee12e
Issue
fixes https://github.com/MetaMask/mobile-planning/issues/1217
Checklist