Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fallback removed #7059

Merged
merged 2 commits into from
Aug 28, 2023
Merged

feat: fallback removed #7059

merged 2 commits into from
Aug 28, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Aug 24, 2023 •
edited

Description
more info here

E2E
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f805764-ed96-435c-ac91-4273dd001a27

Recording
#7025

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner August 24, 2023 21:25
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 24, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title fallback removed feat: fallback removed Aug 24, 2023
@tommasini tommasini added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Aug 24, 2023
@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 28, 2023
@tommasini
Copy link
Contributor Author

Core PR got merged: MetaMask/core#1632

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini added release-7.7.0 Issue or pull request that will be included in release 7.7.0 and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 28, 2023
@tommasini tommasini merged commit 6b2d918 into main Aug 28, 2023
13 checks passed
@tommasini tommasini deleted the feat/822-fallback branch August 28, 2023 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommasini @jpcloureiro @gauthierpetetin