Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [7.6.0] - Token quotes on token details screen #7064

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

tommasini
Copy link
Contributor

Description
Improving the logic when calculating the current price when it's main token of the network on the token details screen

Screenshots/Recordings
http://recordit.co/Ofo0ZlW6aV

Issue

fixes #7062 #7062

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client release-7.6.0 Issue or pull request that will be included in release 7.6.0 labels Aug 25, 2023
@tommasini tommasini requested a review from a team as a code owner August 25, 2023 17:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7064 (92e4aed) into main (9cdb221) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #7064      +/-   ##
==========================================
- Coverage   32.83%   32.83%   -0.01%     
==========================================
  Files         998      998              
  Lines       26665    26666       +1     
  Branches     2091     2091              
==========================================
  Hits         8756     8756              
- Misses      17491    17492       +1     
  Partials      418      418              
Files Changed Coverage Δ
app/components/UI/AssetOverview/AssetOverview.tsx 1.53% <0.00%> (-0.03%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini merged commit 29549a1 into main Aug 25, 2023
18 checks passed
@tommasini tommasini deleted the fix/7063-token-screen-quotes-overview branch August 25, 2023 21:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 25, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.6.0 Issue or pull request that will be included in release 7.6.0 release-7.7.0 Issue or pull request that will be included in release 7.7.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token details page no longer shows the token quote
5 participants