Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update translations #7072

Merged
merged 2 commits into from
Aug 29, 2023
Merged

feat: update translations #7072

merged 2 commits into from
Aug 29, 2023

Conversation

tommasini
Copy link
Contributor

Description
Update translation on import nft screen

image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client release-7.7.0 Issue or pull request that will be included in release 7.7.0 labels Aug 28, 2023
@tommasini tommasini requested a review from a team as a code owner August 28, 2023 22:33
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7072 (3215823) into main (6b2d918) will not change coverage.
The diff coverage is n/a.

❗ Current head 3215823 differs from pull request most recent head 6842d8e. Consider uploading reports for the commit 6842d8e to get more accurate results

@@           Coverage Diff           @@
##             main    #7072   +/-   ##
=======================================
  Coverage   32.83%   32.83%           
=======================================
  Files         998      998           
  Lines       26666    26666           
  Branches     2091     2091           
=======================================
  Hits         8756     8756           
  Misses      17492    17492           
  Partials      418      418           

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini merged commit c785d3d into main Aug 29, 2023
13 checks passed
@tommasini tommasini deleted the translation/1166-translation branch August 29, 2023 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 29, 2023
@gauthierpetetin gauthierpetetin added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 31, 2023
@gauthierpetetin gauthierpetetin added in-progress needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress labels Sep 11, 2023
@gauthierpetetin gauthierpetetin added blocked and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 19, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked release-7.7.0 Issue or pull request that will be included in release 7.7.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants