fix: Warning when rejecting an approval request with id XYZ not found #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistevam
added
the
team-confirmations-system
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7077 +/- ##
==========================================
- Coverage 33.15% 33.15% -0.01%
==========================================
Files 1005 1005
Lines 32655 32656 +1
Branches 8399 8398 -1
==========================================
Hits 10827 10827
- Misses 21828 21829 +1
☔ View full report in Codecov by Sentry. |
vinistevam
force-pushed
the
fix/6860-approval-request-id-not-found
branch
from
1ccd624
to
f0810ca
Compare
matthewwalsh0
approved these changes
Sep 11, 2023
OGPoyraz
approved these changes
Sep 12, 2023
OGPoyraz
approved these changes
Sep 12, 2023
|
The 'Approve token' transaction is rejected after moving to background, no error/wa Screen.Recording.2023-09-12.at.10.18.47.AM.movAndroid build: Screen.Recording.2023-09-12.at.11.21.56.AM.mov |
|
Kudos, SonarCloud Quality Gate passed! |
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
Whenever you deploy an ERC 20, create an approval request, move the app to the background and get it back active again.
Basically, the issue is that
handleAppStateChangeandcomponentWillUnmountare calling reject approval twice without checking if the approval exists.Changes:
Screenshots/Recordings
bug-warning-approval-id-not-found.webm
If applicable, add screenshots and/or recordings to visualize the before and after of your change
To Reproduce
Steps to reproduce the behaviour
The expected behaviour is the transaction being rejected but no warning or error is shown.
E2E
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c4f9cff-ec1b-43ed-8c6f-776cfb46d06f
Issue
fixes #6860
Checklist