refactor: Simplify handleNetworkSwitch utility
#7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7085 +/- ##
==========================================
+ Coverage 32.78% 32.83% +0.04%
==========================================
Files 1001 1001
Lines 26710 26709 -1
Branches 2096 2096
==========================================
+ Hits 8758 8769 +11
+ Misses 17534 17524 -10
+ Partials 418 416 -2
☔ View full report in Codecov by Sentry. |
Gudahtt
added
needs-dev-review
Gudahtt
commented
Aug 30, 2023
Cal-L
reviewed
Aug 30, 2023
The `handleNetworkSwitch` no longer requires the network controller and currency rate controller instances to be passed in. This makes it simpler to use, and reduces the usage of global controller references (which in turn helps reduce the effort of managing breaking changes to those controllers). This relates to MetaMask/mobile-planning#1015
The parameter should already be a string, but this would prevent an exception in the event the wrong type was passed in.
Gudahtt
force-pushed
the
simplify-handle-network-switch
branch
from
e171ecc
to
5bad302
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Cal-L
added
No QA Needed/E2E Only
metamaskbot
added
the
release-7.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
The
handleNetworkSwitchno longer requires the network controller and currency rate controller instances to be passed in. This makes it simpler to use, and reduces the usage of global controller references (which in turn helps reduce the effort of managing breaking changes to those controllers).Issue
This relates to https://github.com/MetaMask/mobile-planning/issues/1015
Checklist