fix: Fix Engine controllerMessenger type errors
#7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
needs-dev-review
The type errors related to the Engine `controllerMessenger` property have been fixed. The controller messenger is now declared correctly with all global actions and events.
Gudahtt
force-pushed
the
fix-engine-controller-messenger-type-error
branch
from
278fa2d
to
de18e73
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
removed
the
needs-dev-review
Gudahtt
added
No QA Needed/E2E Only
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
The type errors related to the Engine
controllerMessengerproperty have been fixed. The controller messenger is now declared correctly with all global actions and events.Issue
This relates to https://github.com/MetaMask/mobile-planning/issues/1015
Checklist