Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bump test-dapp to v7.1.0 #7101

Merged
merged 1 commit into from
Sep 4, 2023
Merged

refactor: Bump test-dapp to v7.1.0 #7101

merged 1 commit into from
Sep 4, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 1, 2023

Description

Bump test-dapp to v7.1.0. This module is exclusively used in e2e. Changes from this version include:

See more here.

Note: at the moment Mobile e2e uses test-dapp only for retrieving contracts, but it does not build the dapp locally and run the tests against localhost. Instead, it goes to the live page. A future refactor should tackle this, so we run against localhost in a controlled environment and we use the same approach in both platforms. Task here.

Screenshots/Recordings

Here you can see the new PPOM section added in the new release of the test dapp.

test-dapp-ppom.mp4

Issue

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@seaona seaona requested a review from a team as a code owner September 1, 2023 09:32
@seaona seaona self-assigned this Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the team-confirmations-secure-ux-PR PR from the confirmations team label Sep 1, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/test-dapp@6.1.0

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seaona
Copy link
Contributor Author

seaona commented Sep 4, 2023

thank you @Gudahtt !!

@seaona seaona merged commit 92572e9 into main Sep 4, 2023
18 checks passed
@seaona seaona deleted the bump-testdapp branch September 4, 2023 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants