Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Typescript errors in utils dir #7109

Merged
merged 14 commits into from
Sep 14, 2023
Merged

fix: Fix Typescript errors in utils dir #7109

merged 14 commits into from
Sep 14, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Sep 1, 2023 •
edited

Description

This PR fixes all TS errors in the utils directory

Screenshots/Recordings

TS errors after running yarn tsc
image

Issue

#6950

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Sep 1, 2023
@Cal-L Cal-L requested a review from a team as a code owner September 1, 2023 20:05
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added in-progress ready-for-dev needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress ready-for-dev labels Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (4fd873a) 33.14% compared to head (95894a4) 33.14%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7109      +/-   ##
==========================================
- Coverage   33.14%   33.14%   -0.01%     
==========================================
  Files        1005     1005              
  Lines       32658    32656       -2     
  Branches     8398     8399       +1     
==========================================
- Hits        10826    10823       -3     
- Misses      21832    21833       +1
Files Changed Coverage Δ
app/util/number/index.js 84.68% <ø> (ø)
app/constants/error.ts 100.00% <100.00%> (ø)
app/util/address/index.js 52.17% <100.00%> (ø)
app/util/password/index.ts 50.00% <100.00%> (-5.18%) ⬇️
app/util/transactions/index.js 67.82% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L
Copy link
Contributor Author

Cal-L commented Sep 1, 2023

E2E Smoke tests - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be6ab37a-5f25-4c55-8e28-be0964fed36c

MarioAslau
MarioAslau previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt reviewed Sep 5, 2023
View reviewed changes
app/util/date/index.test.ts Outdated Show resolved Hide resolved
app/util/networks/index.test.ts Outdated Show resolved Hide resolved
app/util/password/index.ts Show resolved Hide resolved
NicolasMassart
NicolasMassart previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup! Thanks!

leotm
leotm previously approved these changes Sep 6, 2023
View reviewed changes
app/util/transactions/index.js Show resolved Hide resolved
app/util/transactions/index.js Outdated Show resolved Hide resolved
Gudahtt
Gudahtt reviewed Sep 14, 2023
View reviewed changes
app/util/number/index.js Outdated Show resolved Hide resolved
@Cal-L @Gudahtt
Update index.js
95894a4 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
Gudahtt approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Cal-L Cal-L merged commit c3534ed into main Sep 14, 2023
24 checks passed
@Cal-L Cal-L deleted the fix/6950-ts-errors-in-utils branch September 14, 2023 21:03
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 14, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@leotm leotm leotm left review comments

@NicolasMassart NicolasMassart NicolasMassart left review comments

@MarioAslau MarioAslau MarioAslau left review comments

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Cal-L @codecov-commenter @leotm @Gudahtt @NicolasMassart @MarioAslau @gauthierpetetin @metamaskbot