ci: Resolve SonarCloud warnings #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7119 +/- ##
=======================================
Coverage 32.84% 32.84%
=======================================
Files 1001 1001
Lines 26780 26780
Branches 2118 2118
=======================================
Hits 8797 8797
Misses 17559 17559
Partials 424 424 ☔ View full report in Codecov by Sentry. |
Gudahtt
force-pushed
the
resolve-sonarcloud-warnings
branch
2 times, most recently
from
f546274
to
fd19492
Compare
SonarCloud reports currently have two warnings on them: one about not being able to find `main`, the other about detecting a shallow clone. These are both caused by the same problem: the GitHub Action workflow that runs SonarCloud is doing a shallow clone of just the pull request branch. This workflow has been updated to perform a full checkout, including git history for all branches. This should provide the SonarCloud action with all of the information it needs to analyze the pull request, resolving both of these warnings.
Gudahtt
force-pushed
the
resolve-sonarcloud-warnings
branch
from
fd19492
to
f09a8c1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Gudahtt
added
needs-dev-review
NicolasMassart
approved these changes
Sep 4, 2023
Gudahtt
removed
the
needs-dev-review
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
SonarCloud reports currently have two warnings on them: one about not being able to find
main, the other about detecting a shallow clone. These are both caused by the same problem: the GitHub Action workflow that runs SonarCloud is doing a shallow clone of just the pull request branch.This workflow has been updated to perform a full checkout, including git history for all branches. This should provide the SonarCloud action with all of the information it needs to analyze the pull request, resolving both of these warnings.
The Java warning requires an update to the SonarCloud GitHub Action, which requires a change to our organization policy, so that will have to wait for a future PR.
Screenshots/Recordings
Before:
After:
Issue
No related issue
Checklist