refactor: Use selectors for core network state access #7121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7121 +/- ##
==========================================
- Coverage 32.84% 32.52% -0.33%
==========================================
Files 1001 1001
Lines 26780 26776 -4
Branches 2118 2116 -2
==========================================
- Hits 8797 8708 -89
- Misses 17559 17649 +90
+ Partials 424 419 -5
☔ View full report in Codecov by Sentry. |
Gudahtt
force-pushed
the
use-selectors-for-core-network-controller-state
branch
4 times, most recently
from
871e833
to
21c1980
Compare
|
Passing E2E smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd4f0927-b8f0-4c50-a772-50c307cc9154 |
Gudahtt
added
the
needs-dev-review
Replace direct references to NetworkController state with selectors. Most of these examples were skipped in previous selector refactors because they were outside of a React context, so there was no established way to get the Redux state as input for the selector. We can now do that by importing the Redux store directly and calling `getState`. This relates to MetaMask/mobile-planning#1226
Gudahtt
force-pushed
the
use-selectors-for-core-network-controller-state
branch
from
21c1980
to
cfceb7f
Compare
The WalletConnect module has been updated to pass the full Redux state to the `selectChainId` selector, rather than just the background state. The background state was being passed in alone because it was left behind accidentally from an earlier version of this branch, from before the recent store refactors/TypeScript conversion.
|
Kudos, SonarCloud Quality Gate passed!
|
Cal-L
added
No QA Needed/E2E Only
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
Replace direct references to NetworkController state with selectors. Most of these examples were skipped in previous selector refactors because they were outside of a React context, so there was no established way to get the Redux state as input for the selector. We can now do that by importing the Redux store directly and calling
getState.Issue
This relates to https://github.com/MetaMask/mobile-planning/issues/1226
Checklist