-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update controller packages to core v49 #7125
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
5c480d1
to
ba34220
Compare
21c1980
to
cfceb7f
Compare
eff6bb9
to
4f070f6
Compare
4f070f6
to
06b23bf
Compare
@SocketSecurity ignore nonce-tracker@1.1.0 This is our package |
06b23bf
to
108542d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7125 +/- ##
==========================================
+ Coverage 34.60% 34.63% +0.03%
==========================================
Files 1017 1017
Lines 27104 27123 +19
Branches 2197 2198 +1
==========================================
+ Hits 9379 9394 +15
- Misses 17236 17240 +4
Partials 489 489
☔ View full report in Codecov by Sentry. |
e152c95
to
5075548
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This comment was marked as resolved.
This comment was marked as resolved.
6c7b5fc
to
e6f5c69
Compare
09a8ade
to
14e4880
Compare
This has been rebased onto #7197, and the migration renamed from 23 to 24 (a new migration was added on |
3570cfe
to
92e54ff
Compare
14e4880
to
84dfcab
Compare
84dfcab
to
7f5d70d
Compare
The controller packages have been updated to match those present in the core monorepo release v49. See this changelog for details: https://github.com/MetaMask/core/releases/tag/v49.0.0
7f5d70d
to
77f0cb8
Compare
Kudos, SonarCloud Quality Gate passed! |
Updated E2E smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d0babec-489b-4789-ac34-2ead25cae8c5 Edit: Passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No regressions to report. ✅ ✅ looks good to me.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
: PR requires manual QA.No QA/E2E only
: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build
: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passed
label when QA has signed off (Only required if the PR was labeled withneeds-qa
)team-
(orexternal-contributor
label if your not a MetaMask employee)Description
The controller packages have been updated to match those present in the core monorepo release v49. See this changelog for details: https://github.com/MetaMask/core/releases/tag/v49.0.0
The main breaking change is that the
NetworkController
state propertynetwork
has been split intonetworkId
andnetworkStatus
.Screenshots/Recordings
https://recordit.co/GXEdxk9uNp
Wasn't sure exactly what to manually test, but I confirmed that balance updates and incoming transactions seem to be working well, as well as network switching.
Issue
Resolves https://github.com/MetaMask/mobile-planning/issues/1226
Checklist